-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu improvements #3492
Merged
Merged
Menu improvements #3492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `FindByLabel` and `ItemAt` for finding menu items in a menu
Deploying wails with Cloudflare Pages
|
A small change that I had to make to fix an error when running
|
…m.RemoveAccelerator()`
This doesn't seem to work on the defaultMenu. 👇 is not working for me menu := application.DefaultApplicationMenu()
menuItem := menu.FindByLabel("Toggle Fullscreen")
if menuItem != nil {
menu.RemoveMenuItem(menuItem)
}
app.SetMenu(menu) |
Try that ☝️ |
Still does not work menu := application.DefaultApplicationMenu()
menuItem := menu.FindByLabel("Toggle Fullscreen")
if menuItem != nil {
menu.RemoveMenuItem(menuItem)
}
menu.Update()
app.SetMenu(menu) |
Just pushed a fix. However, you'll need to search for the label "Toggle Full Screen" to find the right one. |
This works for me now, thanks I had to do this: menu := application.DefaultApplicationMenu()
menuItem := menu.FindByLabel("Toggle Full Screen")
if menuItem != nil {
menu.RemoveMenuItem(menuItem)
}
app.SetMenu(menu)
menu.Update() |
This worked for my usecase! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cointains:
application.DefaultApplicationMenu() *Menu
which will return the default application menu for the current platformMenu.FindByLabel(label string)
to find a menu item by its label. Returns nil if not found.Menu.ItemAt(index int)
for retrieving menu items by index. Returns nil if out of bounds.Menu.RemoveMenuItem(*MenuItem)
for removing a menu item.MenuItem.RemoveAccelerator()
for removing the accelerator.MenuItem.GetAccelerator() string
for getting a menu item's accelerator.MenuItem.GetSubmenu() *Menu
for getting a submenu (nil if not a submenu item).Menu.Update()
needs calling after any changes.