Refactor to remove STRLEN() part 6 #14796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbra
reviewed
May 18, 2024
zeertzjq
reviewed
May 20, 2024
| tagp.tagname); | ||
| if (!do_search(NULL, '/', '/', pbuf, (long)1, | ||
| if (!do_search(NULL, '/', '/', pbuf, len, (long)1, |
There was a problem hiding this comment.
Why is len used here? Shouldn't this be pbuflen?
There was a problem hiding this comment.
I've created PR #14817 to correct this.
There was a problem hiding this comment.
sorry, I missed that during review.
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
May 21, 2024
Problem: too many strlen() calls in search.c
Solution: refactor code and remove more strlen() calls,
use explicit variable to remember strlen
(John Marriott)
closes: vim/vim#14796
vim/vim@8c85a2a
Co-authored-by: John Marriott <basilisk@internode.on.net>
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
May 21, 2024
Problem: too many strlen() calls in search.c
Solution: refactor code and remove more strlen() calls,
use explicit variable to remember strlen
(John Marriott)
closes: vim/vim#14796
vim/vim@8c85a2a
Co-authored-by: John Marriott <basilisk@internode.on.net>
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
May 21, 2024
Problem: too many strlen() calls in search.c
Solution: refactor code and remove more strlen() calls,
use explicit variable to remember strlen
(John Marriott)
closes: vim/vim#14796
vim/vim@8c85a2a
Co-authored-by: John Marriott <basilisk@internode.on.net>
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
May 21, 2024
Problem: too many strlen() calls in search.c
Solution: refactor code and remove more strlen() calls,
use explicit variable to remember strlen
(John Marriott)
closes: vim/vim#14796
vim/vim@8c85a2a
Co-authored-by: John Marriott <basilisk@internode.on.net>
huangyingw
pushed a commit
to huangyingw/neovim
that referenced
this pull request
May 31, 2024
Problem: too many strlen() calls in search.c
Solution: refactor code and remove more strlen() calls,
use explicit variable to remember strlen
(John Marriott)
closes: vim/vim#14796
vim/vim@8c85a2a
Co-authored-by: John Marriott <basilisk@internode.on.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the number of calls to STRLEN() in search.c. There is nothing tricky here but because all of the call sites needed to change, there are 15 source files involved.
Cheers
John