Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highly improve build-time by excluding "node_modules" folder of submodules (in tailwind's content) #808

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Highly improve build-time by excluding "node_modules" folder of submodules (in tailwind's content) #808

wants to merge 1 commit into from
+6 −6

Conversation

mirismaili
Copy link

@mirismaili mirismaili commented Oct 15, 2023 •
edited

Description

Highly improve build-time (and dev-server startup) by targeting only "dist" folder of submodules in tailwind's content.

As a result of the above change, inner huge "node_modules" folders will be ignored and this causes a big performance and bundle-size improvement.

Type of Change

  • New Example
  • Example updates (Bug fixes, new features, etc.)
  • Other (changes to the codebase, but not to examples)

@mirismaili mirismaili requested review from mehulkar and NicholasLYang and removed request for a team October 15, 2023 11:19
@vercel
Copy link

vercel bot commented Oct 15, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-dir-css-in-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
app-dir-i18n ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
app-dir-share-state ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
edge-api-routes-cache-control ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
edge-api-routes-hello-world ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
edge-api-routes-json-response ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
edge-api-routes-query-parameters ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
edge-functions-authed-proxy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
edge-functions-cookies ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
edge-functions-news ❌ Failed (Inspect) Oct 15, 2023 11:33am
edge-functions-streams ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
edge-geolocation-country-block ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
edge-middleware-modify-request-header ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
edge-user-agent-based-rendering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
example-auth-with-ory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
example-reduce-image-bandwidth-usage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
i18n ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
next-edge-api-route-hello-world ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
next-flask ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
nodejs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
redirect-with-fallback ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
solutions-combining-data-fetching-strategies ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
solutions-image-fallback ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
solutions-image-offset ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
solutions-loading-web-fonts ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
solutions-microfrontends ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
solutions-microfrontends-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
solutions-pagination-with-ssg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
solutions-reuse-responses ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
solutions-script-component-ad ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
solutions-script-component-strategies ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
solutions-testing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
wasm-rust-hello-world ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am
wasm-rust-xor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 11:33am

@vercel
Copy link

vercel bot commented Oct 15, 2023

@mirismaili is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@mehulkar mehulkar removed their request for review October 17, 2023 00:37
@mirismaili mirismaili changed the title Highly improve build-time by targeting "dist" folder of submodules in tailwind's content Highly improve build-time by excluding "node_modules" folder of submodules (in tailwind's content) Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goncy goncy Awaiting requested review from goncy goncy is a code owner

@lfades lfades Awaiting requested review from lfades lfades is a code owner

@leerob leerob Awaiting requested review from leerob leerob is a code owner

@steven-tey steven-tey Awaiting requested review from steven-tey

@lpalmes lpalmes Awaiting requested review from lpalmes lpalmes is a code owner

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang NicholasLYang is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mirismaili