Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the tests in #779 #784

Draft
wants to merge 1 commit into
base: lfades/sol-740-update-testing-example-to-the-app-dir-and-experimental
Choose a base branch
from

Conversation

dvoytenko
Copy link
Member

Description

Demo URL

Type of Change

  • New Example
  • Example updates (Bug fixes, new features, etc.)
  • Other (changes to the codebase, but not to examples)

New Example Checklist

  • 🛫 npm run new-example was used to create the example
  • 📚 The template wasn't used but I carefuly read the Adding a new example steps and implemented them in the example
  • 📱 Is it responsive? Are mobile and tablets considered?

@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-dir-css-in-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
app-dir-i18n ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
app-dir-share-state ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-ab-testing-google-optimize ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-ab-testing-statsig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-ab-testing-simple ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-add-header ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-api-rate-limit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-api-rate-limit-and-tokens ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-basic-auth-password ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-bot-protection-botd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-bot-protection-datadome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-cookies ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-cors ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-crypto ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-feature-flag-configcat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-feature-flag-posthog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-feature-flag-split ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-geolocation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-hostname-rewrites ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-image-response ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-ip-blocking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-ip-blocking-datadome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-json-response ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-jwt-authentication ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-news ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-power-parity-pricing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-power-parity-pricing-strategies ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-query-params-filter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-redirects-upstash ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-functions-streams ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-geolocation-country-block ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-maintenance-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-middleware-modify-request-header ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-rewrites-upstash ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
edge-user-agent-based-rendering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
example-feature-flag-apple-store ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
example-reduce-image-bandwidth-usage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
feature-flag-hypertune ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
feature-flag-launchdarkly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
feature-flag-optimizely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
i18n ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
next-edge-api-route-hello-world ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
nodejs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
solutions-combining-data-fetching-strategies ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
solutions-image-fallback ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
solutions-image-offset ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
solutions-loading-web-fonts ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
solutions-microfrontends ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
solutions-microfrontends-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
solutions-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
solutions-on-demand-isr ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
solutions-pagination-with-ssg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
solutions-reuse-responses ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
solutions-script-component-ad ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
solutions-script-component-strategies ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm
solutions-subdomains-auth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:31pm

@dvoytenko
Copy link
Member Author

@lfades given your approval, do you want me to go ahead and merge this PR into your branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants