New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick fix of failure when use libc allocator in daily CI. #521

Merged

madolson merged 1 commit into valkey-io:unstable from lipzhu:quickfix-dailyci

May 20, 2024

Contributor

lipzhu commented May 20, 2024

Make sdsResize logic align with _sdsnewlen, fix of #476.
Fix:
https://github.com/valkey-io/valkey/actions/runs/9143545732/job/25140329542#step:6:1505
https://github.com/valkey-io/valkey/actions/runs/9135654696/job/25123330670#step:6:1501

Contributor Author

lipzhu commented May 20, 2024

#502 is doing such kind of refactor, I can close it if we are going to fix this in #502.


          Quick fix of failure when use libc allocator in daily CI.

6df690f

Signed-off-by: Lipeng Zhu <lipeng.zhu@intel.com>

enjoy-binbin approved these changes

View reviewed changes

madolson approved these changes

View reviewed changes

Member

madolson left a comment

This is a good quick fix.

Member

madolson commented May 20, 2024

https://github.com/valkey-io/valkey/actions/runs/9164079772

madolson merged commit 122cba5 into valkey-io:unstable

15 checks passed

lipzhu deleted the quickfix-dailyci branch

May 21, 2024 01:22

adetunjii pushed a commit to adetunjii/valkey that referenced this pull request


          Quick fix of failure when use libc allocator in daily CI. (valkey-io#521

)

Make `sdsResize` logic align with `_sdsnewlen`, fix of
valkey-io#476.
Fix:

https://github.com/valkey-io/valkey/actions/runs/9143545732/job/25140329542#step:6:1505

https://github.com/valkey-io/valkey/actions/runs/9135654696/job/25123330670#step:6:1501

Signed-off-by: Lipeng Zhu <lipeng.zhu@intel.com>
Signed-off-by: Samuel Adetunji <adetunjithomas1@outlook.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment