-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused valDup #443
Remove unused valDup #443
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #443 +/- ##
============================================
- Coverage 70.22% 70.19% -0.04%
============================================
Files 109 109
Lines 59956 59958 +2
============================================
- Hits 42104 42086 -18
- Misses 17852 17872 +20
|
As mentioned on slack, can you run the performance test again with more keys and post the updated performance here. As long as there is a meaningful difference, I think it would be worth pulling it. |
For random key and small packets we will see some improvement. For larger packet the improvement is overshadowed by the overall load and is no longer measurable (though logic say it must be there however small). |
@eliblight Can you fix the DCO complaint? |
a956b50
to
b839456
Compare
Sorry for taking a bit to get back around to this, can you address the merge conflicts and update the PR? I'm happy with it otherwise. |
20c8e67
to
3153bc0
Compare
Signed-off-by: Eran Liberty <eran.liberty@gmail.com>
PR by keeping the dict in dictSetVal and not using it. ... but mainly to make @madolson happy Signed-off-by: Eran Liberty <eran.liberty@gmail.com>
09bf2c2
to
f30c6bc
Compare
@madolson your turn |
makes SERVER_CFLAGS='-DSERVER_TEST' compile as well Introduced in #443. Signed-off-by: Eran Liberty <eranl@amazon.com> Co-authored-by: Eran Liberty <eranl@amazon.com>
Remove the unused value duplicate API from dict. It's unused in the codebase and introduces unnecessary overhead. --------- Signed-off-by: Eran Liberty <eran.liberty@gmail.com>
makes SERVER_CFLAGS='-DSERVER_TEST' compile as well Introduced in valkey-io#443. Signed-off-by: Eran Liberty <eranl@amazon.com> Co-authored-by: Eran Liberty <eranl@amazon.com>
It turns out valDup is totally unused in the codebase