Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix food degradation for Eitr #769

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

shawnwallace
Copy link

This update the food degradation prevention to include foods that provide Eitr.

Fix food degradation for eitr.
Uses the same mechanics as the other "smelters", except with different materials.
Copy link
Contributor

@healiha healiha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Grantapher
Copy link

{
il.Insert(++i, new CodeInstruction(OpCodes.Ldfld, field_SharedData_m_foodStamina));
}
else

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably put this in an else if (loads_eitr) and have some sort of error handling for everything else (which should be nothing for now, but if at some point something gets added or changed we would see this)

(I stumbled upon this by chance and have not been contributing to Valheim+ yet, so please see my comment with a grain of salt because you know and understand this code much better!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants