Configurable cache directory #119
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove config/data dir config as its not necessary fmt idk
Buckminsterfullerene02
force-pushed
the
config-changes
branch
from
609b044
to
d137ad0
Compare
|
Removed settings for config/data dir because it doesn't make any sense why'd you want to move those. |
Buckminsterfullerene02
changed the title
trumank
force-pushed
the
master
branch
2 times, most recently
from
9bc18cb
to
ad23a7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Draft]
Reason for implementation
If the user changes cache dir, it needs to delete the existing cache from the previous location and make the directory at the new location. I'm not having it copy the cache dir because it's usually multiple GBs which can be a long ass process for slower machines. Would need extra complexity like progress bar or something. Saying that, deleting multiple GBs can take a while too so maybe not have that part? Then again, it's expected to delete old cache files anyway
Have not been able to actually test this code yet (aside from the UI changes)