Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-128889 / 24.10 / Remove ability to configure swap from the API #13726

Merged
merged 4 commits into from
May 27, 2024

Conversation

Qubad786
Copy link
Contributor

Context

We now don't try to configure or manage swap and finally now we are removing it from our API as well so consumers won't be able to configure this anymore via our API.

@Qubad786 Qubad786 requested a review from a team May 15, 2024 14:15
@bugclerk bugclerk changed the title Remove ability to configure swap from the API NAS-128889 / 24.10 / Remove ability to configure swap from the API May 15, 2024
@bugclerk
Copy link
Contributor

Copy link
Contributor

@yocalebo yocalebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the perfect opportunity to remove the create_swap references through the API. Can you please go ahead and do that in this PR since you're making changes to the db.

@Qubad786 Qubad786 merged commit dc9708e into master May 27, 2024
3 checks passed
@Qubad786 Qubad786 deleted the NAS-128889 branch May 27, 2024 13:36
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants