New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vnstat*: fix flag, rename placeholder and add Spanish translation #12775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasecilu
requested review from
cyqsimon,
navarroaxel,
kant and
tricantivu
as code owners
May 11, 2024 01:31
github-actions
bot
added
page edit
Changes to an existing page(s).
translation
Translate pages from one language to another.
labels
May 11, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
kbdharun
approved these changes
May 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for your contribution.
Edit. I closed and reopened the pull request to retrigger the frozen CLA check.
sebastiaanspeck
approved these changes
May 11, 2024
tricantivu
reviewed
May 12, 2024
Co-authored-by: Alejandro Cervera <96702705+tricantivu@users.noreply.github.com>
Co-authored-by: Alejandro Cervera <96702705+tricantivu@users.noreply.github.com>
Co-authored-by: Alejandro Cervera <96702705+tricantivu@users.noreply.github.com>
Co-authored-by: Alejandro Cervera <96702705+tricantivu@users.noreply.github.com>
Co-authored-by: Alejandro Cervera <96702705+tricantivu@users.noreply.github.com>
kant
reviewed
May 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Alejandro Cervera <96702705+tricantivu@users.noreply.github.com>
tricantivu
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems before the flag was
--top10
but now the flag is--top
and accepts an argument.common
,linux
,osx
,windows
,sunos
,android
, etc.