New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sops: update page #12719
sops: update page #12719
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Magrid <magrid0@proton.me>
Co-authored-by: Magrid <magrid0@proton.me>
Ok, nice So now just wait for another ok and then it gets pushed? @Magrid0 But why have the file paths to be in that format? actually wanted to add one simpler syntax example |
Yep!
Because the Style Guide say they have to be written in this way |
Ok, makes sense, head guidelines in mind with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to tldr and thanks for your contribution. LGTM, after @sebastiaanspeck's suggestion above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, i think it'll be ready to merge after sebastiaanspeck suggestion
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
Since the author of this PR has been inactive for a long time, I have made the suggested changes. Maintainers Guide says:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGGM, after the suggestions are fixed
Hi,
my first public contribution here, so greetings to my Ma! :)
I think this one is essential, got stuck twice now by remembering this one and so I guess it should be shared with others
common
,linux
,osx
,windows
,sunos
,android
, etc.