Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arecord, convert: edit pages #12644

Merged
merged 14 commits into from May 20, 2024
Merged

arecord, convert: edit pages #12644

merged 14 commits into from May 20, 2024

Conversation

TheFibonacciEffect
Copy link
Contributor

@TheFibonacciEffect TheFibonacciEffect commented Apr 14, 2024 •
edited

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@CLAassistant
Copy link

CLAassistant commented Apr 14, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the page edit Changes to an existing page(s). label Apr 14, 2024
@tldr-bot

This comment was marked as outdated.

Sign in to view
@tldr-bot

This comment was marked as outdated.

Sign in to view
@tldr-bot

This comment was marked as outdated.

Sign in to view
@gutjuri gutjuri changed the title add command to resize to desired size and add command to test microphone arecord, convert: edit pages Apr 14, 2024
@tldr-bot

This comment was marked as outdated.

Sign in to view
@tldr-bot

This comment was marked as outdated.

Sign in to view
@TheFibonacciEffect
Copy link
Contributor Author

TheFibonacciEffect commented Apr 14, 2024 •
edited

Allright now its ready : )
These commands are very useful to me and I hope they are to others as well, sorry that it took me several tries with the formatting...

sebastiaanspeck
sebastiaanspeck reviewed Apr 16, 2024
View reviewed changes
pages/common/convert.md Outdated Show resolved Hide resolved
pages/common/convert.md Outdated Show resolved Hide resolved
TheFibonacciEffect and others added 2 commits April 16, 2024 15:17
@TheFibonacciEffect @sebastiaanspeck
Update pages/common/convert.md
9591c0b 
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
@TheFibonacciEffect
Merge branch 'main' into main
37e0f0e
@TheFibonacciEffect
Copy link
Contributor Author

Is there anything that needs to be fixed before merging?

@TheFibonacciEffect @sebastiaanspeck
Update pages/common/convert.md
1039d2c 
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
kbdharun
kbdharun reviewed May 12, 2024
View reviewed changes
pages/common/convert.md Outdated Show resolved Hide resolved
@TheFibonacciEffect @kbdharun
Update pages/common/convert.md
c8b818b 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
spageektti
spageektti approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @TheFibonacciEffect. Thanks for your contribution!

@spageektti spageektti merged commit b93aed1 into tldr-pages:main May 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbdharun kbdharun kbdharun left review comments

@CleanMachine1 CleanMachine1 CleanMachine1 left review comments

@vitorhcl vitorhcl vitorhcl left review comments

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@spageektti spageektti spageektti approved these changes

@cyqsimon cyqsimon Awaiting requested review from cyqsimon cyqsimon is a code owner

Assignees
No one assigned
Labels
page edit Changes to an existing page(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@TheFibonacciEffect @CLAassistant @tldr-bot @sebastiaanspeck @kbdharun @CleanMachine1 @vitorhcl @spageektti