New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bug with precommit check using nvs
#12571
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okey.
Co-authored-by: Fazle Arefin <fazlearefin@users.noreply.github.com>
@fazlearefin Done! |
How would this affect users of nvm that would like to run a nonstandard version of npm? |
This PR contains fixes only for |
Typo :) Of course I meant to ask "How would this affect users of nvs that would like to run a nonstandard version of npm?" :) |
I don't even know if anyone has bugs with this - I'll look into them. |
common
,linux
,osx
,windows
,sunos
,android
, etc.In this patch, I added to the
.husky/pre-commit
file an automatic detection of the use ofnvs
, if the user hasnvs
- then the pre-commit script will use the standard version of NodeJSIf the standard version is not installed, this can be done using a simple command:
This commit closes the issue with this error - #12565