Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error boundary handle removeChild error #26580

Merged
merged 3 commits into from
May 21, 2024
Merged

Error boundary handle removeChild error #26580

merged 3 commits into from
May 21, 2024

Conversation

joshenlim
Copy link
Member

image

@joshenlim joshenlim requested a review from a team as a code owner May 20, 2024 13:56
@vercel Vercel
Copy link

vercel bot commented May 20, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
database-new 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 20, 2024 2:41pm
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 2:41pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 20, 2024 2:41pm
studio ⬜️ Ignored (Inspect) Visit Preview May 20, 2024 2:41pm
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview May 20, 2024 2:41pm
zone-www-dot-com ⬜️ Ignored (Inspect) Visit Preview May 20, 2024 2:41pm

@supabase Supabase
Copy link

supabase bot commented May 20, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.

Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎.

joshenlim and others added 2 commits May 20, 2024 22:29
@joshenlim @alaister
Update apps/studio/components/ui/ErrorBoundaryState.tsx
b168a1b 
Co-authored-by: Alaister Young <alaister@users.noreply.github.com>
@joshenlim
Lint
87dada7
@joshenlim joshenlim requested a review from alaister May 20, 2024 14:43
alaister
alaister approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshenlim joshenlim merged commit 429f3d2 into master May 21, 2024
14 checks passed
@joshenlim joshenlim deleted the chore/error-boundary-handle-removeChild-error branch May 21, 2024 02:55
@joshenlim joshenlim mentioned this pull request May 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaister alaister alaister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshenlim @alaister