[#19921] feat: remove key pair action #20002

mohsen-ghafouri · 2024-05-13T17:34:26Z

fixes #19921

Summary

Implement the remove key-pair feature for the wallet settings.

Areas that maybe impacted

Keypairs and account screen
Remove key pair

Steps to test

Open Wallet setting
Click on not default keypair's action button
Click on remove key pair

Result

Simulator.Screen.Recording.-.iPhone.13.-.2024-05-24.at.15.11.40.mp4

status: ready

status-im-auto · 2024-05-13T17:37:22Z

Jenkins Builds

Click to see older builds (31)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`300edb0`	#1	2024-05-13 17:37:21	~2 min	`tests`	📄`log`
✔️	`300edb0`	#1	2024-05-13 17:41:09	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`300edb0`	#1	2024-05-13 17:41:52	~7 min	`android`	🤖`apk` 📲
✔️	`300edb0`	#1	2024-05-13 17:44:28	~9 min	`ios`	📱`ipa` 📲

✔️	`2003e5b`	#2	2024-05-14 16:58:28	~4 min	`tests`	📄`log`
✔️	`2003e5b`	#2	2024-05-14 16:59:56	~5 min	`android`	🤖`apk` 📲
✔️	`2003e5b`	#2	2024-05-14 17:01:06	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`2003e5b`	#2	2024-05-14 17:02:54	~8 min	`ios`	📱`ipa` 📲

✔️	`3f7b94c`	#3	2024-05-15 05:19:32	~3 min	`tests`	📄`log`
✔️	`3f7b94c`	#3	2024-05-15 05:23:10	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`3f7b94c`	#3	2024-05-15 05:24:17	~8 min	`android`	🤖`apk` 📲
✔️	`3f7b94c`	#3	2024-05-15 05:26:32	~10 min	`ios`	📱`ipa` 📲

✔️	`2d301da`	#4	2024-05-23 12:38:52	~4 min	`tests`	📄`log`
✔️	`2d301da`	#4	2024-05-23 12:40:49	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`2d301da`	#4	2024-05-23 12:41:47	~7 min	`android`	🤖`apk` 📲
✔️	`2d301da`	#4	2024-05-23 12:44:18	~9 min	`ios`	📱`ipa` 📲

✔️	`4e02be3`	#5	2024-05-23 15:43:19	~4 min	`tests`	📄`log`
✔️	`4e02be3`	#5	2024-05-23 15:46:13	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`4e02be3`	#5	2024-05-23 15:46:22	~7 min	`android`	🤖`apk` 📲
✔️	`4e02be3`	#5	2024-05-23 15:48:35	~9 min	`ios`	📱`ipa` 📲

✔️	`6d92fad`	#6	2024-05-24 12:22:56	~6 min	`android`	🤖`apk` 📲
✔️	`6d92fad`	#6	2024-05-24 12:23:15	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`6d92fad`	#6	2024-05-24 12:27:33	~10 min	`ios`	📱`ipa` 📲

✔️	`9235ceb`	#8	2024-05-24 14:44:05	~4 min	`tests`	📄`log`
✔️	`9235ceb`	#8	2024-05-24 14:46:00	~6 min	`android`	🤖`apk` 📲
✔️	`9235ceb`	#8	2024-05-24 14:46:08	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`9235ceb`	#8	2024-05-24 14:49:44	~9 min	`ios`	📱`ipa` 📲

✔️	`a560944`	#9	2024-05-24 16:21:55	~3 min	`tests`	📄`log`
✔️	`a560944`	#9	2024-05-24 16:24:22	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`a560944`	#9	2024-05-24 16:26:53	~8 min	`android`	🤖`apk` 📲
✔️	`a560944`	#9	2024-05-24 16:31:24	~13 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`8b6861e`	#10	2024-05-27 12:12:13	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`8b6861e`	#10	2024-05-27 12:13:01	~6 min	`tests`	📄`log`
✔️	`8b6861e`	#10	2024-05-27 12:15:06	~8 min	`android`	🤖`apk` 📲
✔️	`8b6861e`	#10	2024-05-27 12:20:15	~14 min	`ios`	📱`ipa` 📲

✔️	`7a87cb4`	#11	2024-05-27 12:46:10	~4 min	`tests`	📄`log`
✔️	`7a87cb4`	#11	2024-05-27 12:48:25	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`7a87cb4`	#11	2024-05-27 12:49:19	~7 min	`android`	🤖`apk` 📲
✔️	`7a87cb4`	#11	2024-05-27 12:55:10	~13 min	`ios`	📱`ipa` 📲

mohsen-ghafouri · 2024-05-16T07:27:04Z

blocked by this issue #19472, when i want to remove a key pair it throws error no key for given address or file.

will re-test after #19531

seanstrom

Nice stuff ✅

src/status_im/contexts/settings/wallet/keypairs_and_accounts/actions/view.cljs

src/quo/components/text_combinations/page_top/style.cljs

seanstrom · 2024-05-24T09:23:17Z

@mohsen-ghafouri One thing I noticed is that the removed-keypair toast should be in light mode 🌤️

src/status_im/contexts/settings/wallet/events.cljs

mohsen-ghafouri · 2024-05-24T12:17:14Z

@seanstrom good catch, I noticed they removed theme from toast's props. resolved.

BalogunofAfrica

LGTM! ✅

src/status_im/contexts/settings/wallet/keypairs_and_accounts/remove/view.cljs

smohamedjavid

Looks good overall. Nice work 🚀 🙌 @mohsen-ghafouri

Just a component change in the confirmation sheet.

smohamedjavid · 2024-05-24T13:25:24Z

src/status_im/contexts/settings/wallet/keypairs_and_accounts/remove/view.cljs

+     [quo/page-top
+      {:container-style style/header-container
+       :title           (i18n/label :t/remove-key-pair-and-derived-accounts)
+       :title-size      :heading-2
+       :description     :context-tag
+       :context-tag     {:type    :icon
+                         :size    24
+                         :context name
+                         :icon    :i/seed-phrase}}]


@mohsen-ghafouri - We need to use the drawer-top component here. That has the heading-2 text size.

I think drawer-top doesn't support icon, i will update it and use it here

@smohamedjavid thanks for pointing it out, I replaced

status-im-auto · 2024-05-24T13:38:18Z

60% of end-end tests have passed

Total executed tests: 52
Failed tests: 20
Expected to fail tests: 1
Passed tests: 31

IDs of failed tests: 727230,702809,702733,702784,702732,702840,703495,702948,702783,703297,704615,727229,703496,703202,702786,702807,702808,727232,702845,703629

IDs of expected to fail tests: 703503

Failed tests (20)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Test setup failed: critical/chats/test_1_1_public_chats.py:548: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:410: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:162: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:159: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device 2: Tap on found: Button Device 2: Attempt 0 is successful clicking close-activity-center Test setup failed: critical/chats/test_1_1_public_chats.py:548: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:410: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:162: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:159: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Test setup failed: critical/chats/test_1_1_public_chats.py:548: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:410: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:162: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:159: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733

Device 2: Find Text by xpath: //*[starts-with(@text,'smth I should edit')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
Device 2: Text is Sent

critical/chats/test_1_1_public_chats.py:472: in test_1_1_chat_text_message_delete_push_disappear
    self.chat_2.chat_element_by_text(message_after_edit_1_1).wait_for_status_to_be("Delivered")
../views/chat_view.py:225: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Test setup failed: critical/chats/test_public_chat_browsing.py:839: in prepare_devices self.community_2.join_community() ../views/chat_view.py:419: in join_community ChatView(self.driver).chat_element_by_text("https://status.app/c/").click_on_link_inside_message_body() ../views/chat_view.py:175: in click_on_link_inside_message_body self.message_body.wait_for_visibility_of_element(30) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by xpath:`//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` is not found on the screen after wait_for_visibility_of_element
2. test_community_hashtag_links_to_community_channels, id: 702948
Test setup failed: critical/chats/test_public_chat_browsing.py:839: in prepare_devices self.community_2.join_community() ../views/chat_view.py:419: in join_community ChatView(self.driver).chat_element_by_text("https://status.app/c/").click_on_link_inside_message_body() ../views/chat_view.py:175: in click_on_link_inside_message_body self.message_body.wait_for_visibility_of_element(30) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by xpath:`//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` is not found on the screen after wait_for_visibility_of_element
3. test_community_mentions_push_notification, id: 702786
Device 2: Joining community Device 2: Looking for a message by text: https://status.app/c/ Test setup failed: critical/chats/test_public_chat_browsing.py:839: in prepare_devices self.community_2.join_community() ../views/chat_view.py:419: in join_community ChatView(self.driver).chat_element_by_text("https://status.app/c/").click_on_link_inside_message_body() ../views/chat_view.py:175: in click_on_link_inside_message_body self.message_body.wait_for_visibility_of_element(30) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by xpath:`//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_leave, id: 702845
Test setup failed: critical/chats/test_public_chat_browsing.py:839: in prepare_devices self.community_2.join_community() ../views/chat_view.py:419: in join_community ChatView(self.driver).chat_element_by_text("https://status.app/c/").click_on_link_inside_message_body() ../views/chat_view.py:175: in click_on_link_inside_message_body self.message_body.wait_for_visibility_of_element(30) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by xpath:`//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` is not found on the screen after wait_for_visibility_of_element
5. test_community_join_when_node_owner_offline, id: 703629
Test setup failed: critical/chats/test_public_chat_browsing.py:839: in prepare_devices self.community_2.join_community() ../views/chat_view.py:419: in join_community ChatView(self.driver).chat_element_by_text("https://status.app/c/").click_on_link_inside_message_body() ../views/chat_view.py:175: in click_on_link_inside_message_body self.message_body.wait_for_visibility_of_element(30) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by xpath:`//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` is not found on the screen after wait_for_visibility_of_element

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
`critical/test_wallet.py:119: in test_wallet_send_asset_from_drawer self.wallet_view.navigate_back_to_wallet_view() 'TestWalletMultipleDevice' object has no attribute 'wallet_view'`
2. test_wallet_send_eth, id: 727229
Device 1: Swiping right on element SlideButton Device 1: Find `SlideButton` by `xpath`: `//[@resource-id='slide-button-track']` critical/test_wallet.py:111: in test_wallet_send_eth self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send) ../views/wallet_view.py:100: in send_asset self.confirm_transaction() ../views/wallet_view.py:87: in confirm_transaction self.slide_and_confirm_with_password() ../views/wallet_view.py:81: in slide_and_confirm_with_password self.slide_button_track.slide() ../views/base_view.py:257: in slide self.swipe_right_on_element(width_percentage=1.3, start_x=100) ../views/base_element.py:308: in swipe_right_on_element location, size = self.get_element_coordinates() ../views/base_element.py:294: in get_element_coordinates element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: SlideButton by xpath: `//[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestWalletOneDevice:

1. test_wallet_add_remove_watch_only_account, id: 727232

Device 1: Text is 0x8d2413447ff297d30bdc475f6d5cb00254685aae
Device 1: Click system back button

critical/test_wallet.py:213: in test_wallet_add_remove_watch_only_account
    self.home_view.driver.fail(
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Incorrect address '0x8d2413447ff297d30bdc475f6d5cb00254685aae' is shown when swiping between accounts, expected one is '0x8d2413447ff297d30bdc475f6d5cb00254685aae'

Device sessions

Device 1:

Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/home_view.py:410: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:162: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:159: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 3: Button by xpath:`//[contains(@text, 'user admin')]/ancestor::[@content-desc='activity']/[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
2. test_group_chat_mute_chat, id: 703495
Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/home_view.py:410: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:162: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:159: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 3: Button by xpath:`//[contains(@text, 'user admin')]/ancestor::[@content-desc='activity']/[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element [[Chat is not unmuted after expected time: https://github.com//issues/19627]]
3. test_group_chat_send_image_save_and_share, id: 703297
Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/home_view.py:410: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:162: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:159: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 3: Button by xpath:`//[contains(@text, 'user admin')]/ancestor::[@content-desc='activity']/[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
4. test_group_chat_reactions, id: 703202
Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/home_view.py:410: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:162: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:159: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 3: Button by xpath:`//[contains(@text, 'user admin')]/ancestor::[@content-desc='activity']/[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
5. test_group_chat_join_send_text_messages_push, id: 702807
Device 2: Tap on found: Button Device 2: Attempt 0 is successful clicking close-activity-center Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/home_view.py:410: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:162: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:159: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 3: Button by xpath:`//[contains(@text, 'user admin')]/ancestor::[@content-desc='activity']/[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element [[Issue with a message status - Sent instead of Delivered, https://github.com//issues/20126]] Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
6. test_group_chat_offline_pn, id: 702808
Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/home_view.py:410: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:162: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:159: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 3: Button by xpath:`//[contains(@text, 'user admin')]/ancestor::[@content-desc='activity']/[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Device 2: Tap on found: SendMessageButton Device 1: Looking for a message by text: test message critical/chats/test_public_chat_browsing.py:528: in test_community_emoji_send_copy_paste_reply chat_element_1.wait_for_element(60) ../views/base_element.py:129: in wait_for_element raise TimeoutException( Device `1`: `ChatElementByText` by` xpath`: `//*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_edit_delete_message_when_offline, id: 704615
Device 1: Looking for a message by text: message to edit Device 1: Looking for a message by text: message to delete `critical/chats/test_public_chat_browsing.py:783: in test_community_edit_delete_message_when_offline self.channel_1.driver.fail("Message '%s' was not received" % message) base_test_case.py:178: in fail pytest.fail('Device %s: %s' % (self.number, text)) Device 1: Message 'message to delete' was not received` Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Expected to fail tests (1)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (31)

Click to expand

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

status-im-auto · 2024-05-24T17:16:01Z

87% of end-end tests have passed

Total executed tests: 52
Failed tests: 4
Expected to fail tests: 3
Passed tests: 45

IDs of failed tests: 727230,727229,702808,727232

IDs of expected to fail tests: 703495,703503,702807

Failed tests (4)

Click to expand

Rerun failed tests

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
`critical/test_wallet.py:119: in test_wallet_send_asset_from_drawer self.wallet_view.navigate_back_to_wallet_view() 'TestWalletMultipleDevice' object has no attribute 'wallet_view'`
2. test_wallet_send_eth, id: 727229
Device 1: Swiping right on element SlideButton Device 1: Find `SlideButton` by `xpath`: `//[@resource-id='slide-button-track']` critical/test_wallet.py:111: in test_wallet_send_eth self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send) ../views/wallet_view.py:100: in send_asset self.confirm_transaction() ../views/wallet_view.py:87: in confirm_transaction self.slide_and_confirm_with_password() ../views/wallet_view.py:81: in slide_and_confirm_with_password self.slide_button_track.slide() ../views/base_view.py:257: in slide self.swipe_right_on_element(width_percentage=1.3, start_x=100) ../views/base_element.py:308: in swipe_right_on_element location, size = self.get_element_coordinates() ../views/base_element.py:294: in get_element_coordinates element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: SlideButton by xpath: `//[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_offline_pn, id: 702808
Device 3: Looking for a message by text: message from old member Device 3: Looking for a message by text: message from new member `critical/chats/test_group_chat.py:326: in test_group_chat_offline_pn self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) message from old member if not shown for device 2` Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_watch_only_account, id: 727232

Device 1: Text is 0x8d2413447ff297d30bdc475f6d5cb00254685aae
Device 1: Click system back button

critical/test_wallet.py:213: in test_wallet_add_remove_watch_only_account
    self.home_view.driver.fail(
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Incorrect address '0x8d2413447ff297d30bdc475f6d5cb00254685aae' is shown when swiping between accounts, expected one is '0x8d2413447ff297d30bdc475f6d5cb00254685aae'

Device sessions

Device 1:

Steps, video, logs

Expected to fail tests (3)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495
# STEP: Change device time so chat will be unmuted by timer Device 2: Long press on `ChatElement` `critical/chats/test_group_chat.py:466: in test_group_chat_mute_chat self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Chat is still muted after timeout` [[Chat is not unmuted after expected time: https://github.com//issues/19627]] Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_join_send_text_messages_push, id: 702807
Device 2: Find `Text` by `xpath`: `//[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-status']/android.widget.TextView` Device 2: `Text` is `Sent` `critical/chats/test_group_chat.py:97: in test_group_chat_join_send_text_messages_push self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120) ../views/chat_view.py:225: in wait_for_status_to_be raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status)) Message status was not changed to Delivered, it's Sent` [[Issue with a message status - Sent instead of Delivered, https://github.com//issues/20126]] Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (45)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_join_when_node_owner_offline, id: 703629
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

mohsen-ghafouri · 2024-05-25T21:13:05Z

@status-im/mobile-qa could you please check the test results? I skip manual QA as this action is still behind the feature flag

smohamedjavid

🚀

churik · 2024-05-27T10:40:33Z

@mohsen-ghafouri sorry for delay, ready to go

mohsen-ghafouri self-assigned this May 13, 2024

status-github-bot bot added this to REVIEW in Pipeline for QA May 13, 2024

mohsen-ghafouri force-pushed the feat/remove-key-pair branch 2 times, most recently from 2003e5b to 3f7b94c Compare May 15, 2024 05:15

mohsen-ghafouri force-pushed the feat/remove-key-pair branch 2 times, most recently from 2d301da to 4e02be3 Compare May 23, 2024 15:38

mohsen-ghafouri requested review from seanstrom, smohamedjavid and BalogunofAfrica May 23, 2024 15:57

mohsen-ghafouri marked this pull request as ready for review May 23, 2024 15:58

seanstrom approved these changes May 24, 2024

View reviewed changes

src/status_im/contexts/settings/wallet/keypairs_and_accounts/actions/view.cljs Show resolved Hide resolved

src/quo/components/text_combinations/page_top/style.cljs Outdated Show resolved Hide resolved

BalogunofAfrica reviewed May 24, 2024

View reviewed changes

src/status_im/contexts/settings/wallet/events.cljs Outdated Show resolved Hide resolved

mohsen-ghafouri force-pushed the feat/remove-key-pair branch from 4e02be3 to 6d92fad Compare May 24, 2024 12:16

mohsen-ghafouri moved this from REVIEW to E2E Tests in Pipeline for QA May 24, 2024

mohsen-ghafouri added the skip-manual-qa label May 24, 2024

BalogunofAfrica approved these changes May 24, 2024

View reviewed changes

smohamedjavid reviewed May 24, 2024

View reviewed changes

src/status_im/contexts/settings/wallet/keypairs_and_accounts/remove/view.cljs Outdated Show resolved Hide resolved

smohamedjavid reviewed May 24, 2024

View reviewed changes

mohsen-ghafouri force-pushed the feat/remove-key-pair branch 2 times, most recently from f62e9e2 to 9235ceb Compare May 24, 2024 14:39

mohsen-ghafouri moved this from E2E Tests to REVIEW in Pipeline for QA May 24, 2024

mohsen-ghafouri moved this from REVIEW to E2E Tests in Pipeline for QA May 24, 2024

mohsen-ghafouri force-pushed the feat/remove-key-pair branch from 9235ceb to a560944 Compare May 24, 2024 16:17

mohsen-ghafouri mentioned this pull request May 24, 2024

[#20035] feat: import missing key pair by scanning QR code #20144

Merged

seanstrom mentioned this pull request May 27, 2024

Feature: Implement import of key-pair with recovery phrase inside wallet settings #20181

Open

smohamedjavid approved these changes May 27, 2024

View reviewed changes

churik moved this from E2E Tests to MERGE in Pipeline for QA May 27, 2024

mohsen-ghafouri force-pushed the feat/remove-key-pair branch from a560944 to 8b6861e Compare May 27, 2024 12:05

mohsen-ghafouri added 4 commits May 27, 2024 15:41

[#19921] feat: remove key pair action

0cf0d00

[#19921] feat: integrate remove key pair endpoint

9146d43

[#19921] fix: reviewer feedbacks

816acf0

[#19921] fix: reviewer feedbacks

7a87cb4

mohsen-ghafouri force-pushed the feat/remove-key-pair branch from 8b6861e to 7a87cb4 Compare May 27, 2024 12:41

mohsen-ghafouri merged commit de71df8 into develop May 27, 2024
6 checks passed

Pipeline for QA automation moved this from MERGE to DONE May 27, 2024

mohsen-ghafouri deleted the feat/remove-key-pair branch May 27, 2024 12:58

[#19921] feat: remove key pair action #20002

[#19921] feat: remove key pair action #20002

Conversation

mohsen-ghafouri commented May 13, 2024 • edited

Summary

Areas that maybe impacted

Steps to test

Result

status-im-auto commented May 13, 2024 • edited

Jenkins Builds

mohsen-ghafouri commented May 16, 2024 • edited

seanstrom left a comment

Choose a reason for hiding this comment

seanstrom commented May 24, 2024

mohsen-ghafouri commented May 24, 2024

BalogunofAfrica left a comment • edited

Choose a reason for hiding this comment

smohamedjavid left a comment

Choose a reason for hiding this comment

smohamedjavid May 24, 2024

Choose a reason for hiding this comment

mohsen-ghafouri May 24, 2024

Choose a reason for hiding this comment

mohsen-ghafouri May 24, 2024

Choose a reason for hiding this comment

status-im-auto commented May 24, 2024

60% of end-end tests have passed

Failed tests (20)

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestWalletMultipleDevice:

Class TestWalletOneDevice:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

Expected to fail tests (1)

Class TestCommunityOneDeviceMerged:

Passed tests (31)

Class TestDeepLinksOneDevice:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestWalletOneDevice:

Class TestCommunityMultipleDeviceMerged:

status-im-auto commented May 24, 2024

87% of end-end tests have passed

Failed tests (4)

Class TestWalletMultipleDevice:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestWalletOneDevice:

Expected to fail tests (3)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Passed tests (45)

Class TestCommunityMultipleDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestDeepLinksOneDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityMultipleDevicePR:

Class TestWalletOneDevice:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

mohsen-ghafouri commented May 25, 2024 • edited

smohamedjavid left a comment

Choose a reason for hiding this comment

churik commented May 27, 2024

mohsen-ghafouri commented May 13, 2024 •

edited

status-im-auto commented May 13, 2024 •

edited

mohsen-ghafouri commented May 16, 2024 •

edited

BalogunofAfrica left a comment •

edited

mohsen-ghafouri commented May 25, 2024 •

edited