Add ability to spawn actor from any logic #4724
Conversation
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| if (this._processingStatus === ProcessingStatus.Running) { | ||
| actor.start(); | ||
| } |
There was a problem hiding this comment.
what about the actors spawned when this._processingStatus === ProcessingStatus.NotStarted?
| }, | ||
| spawnChild: <T extends AnyActorLogic>( | ||
| logic: T, | ||
| actorOptions?: ActorOptions<T> |
There was a problem hiding this comment.
this should reuse the type tricks from here:
xstate/packages/core/src/createActor.ts
Lines 763 to 770 in 8a7ea9e
| @@ -2106,6 +2106,10 @@ export interface ActorScope< | |||
| defer: (fn: () => void) => void; | |||
| system: TSystem; | |||
| stopChild: (child: AnyActorRef) => void; | |||
| spawnChild: <T extends AnyActorLogic>( | |||
There was a problem hiding this comment.
| @@ -73,6 +75,7 @@ export type InvokeCallback< | |||
| * the listener is then called whenever events are received by the callback actor | |||
| */ | |||
| receive: Receiver<TEvent>; | |||
| spawn: ActorScope<any, any>['spawnChild']; | |||
There was a problem hiding this comment.
shouldn't all of those actor logics receive stopChild as well?
There was a problem hiding this comment.
There is a substantial problem with this PR that is somewhat mentioned in this comment here:
xstate/packages/core/src/createActor.ts
Lines 588 to 592 in 91549ce
When the parent actor gets stopped its children should get stopped too. There is no mechanism implemented here that would achieve this for this new functionality.
This PR adds the ability for any actor logic to spawn an actor, which is a core tenet of the actor model.