Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clip.fromThree() to create Clip from Three.js AnimationClip #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ArsenicBismuth
Copy link

@ArsenicBismuth ArsenicBismuth commented Aug 21, 2023

Just a simple utility to add more method to create ossos.Clip(), need the armature of the source model to get the bone mapping data.

@ArsenicBismuth ArsenicBismuth changed the title Clip.fromThree() to convert from Three.js clip Clip.fromThree() to create Clip from Three.js AnimationClip Aug 21, 2023
@trusktr
Copy link

trusktr commented Apr 25, 2024

This is a great idea. If Clip/etc will be library agnostic though, it may need to be in a separate utility though, f.e. ThreeClipUtils.fromThree(threeAnimClip) would return a Clip. Otherwise, we'd also have to add the method for Babylon in the same class, and for Playcanvas, etc, coupling all libraries together (import Clip and you get all the rendering libraries, massive download).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants