Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report websocket errors to stderr #2255

Merged
merged 1 commit into from
May 30, 2024

Conversation

lukehutch
Copy link
Contributor

@lukehutch lukehutch commented May 15, 2024

Currently web socket errors are not reported to stderr in most cases (although in one strange case, they are reported and not caught by the caller: dart-lang/sdk#55664 )

This PR prints websocket errs to stderr.

Solves #1679.

Pre-launch Checklist

  • I read the Contribute page and followed the process outlined there for submitting PRs.
  • This update contains only one single feature or bug fix and nothing else. (If you are submitting multiple fixes, please make multiple PRs.)
  • I read and followed the Dart Style Guide and formatted the code with dart format.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///), and made sure that the documentation follows the same style as other Serverpod documentation. I checked spelling and grammar.
  • I added new tests to check the change I am making.
  • All existing and new tests are passing.
  • Any breaking changes are documented below.

Copy link
Collaborator

@Isakdl Isakdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Isakdl Isakdl merged commit 6cbaae5 into serverpod:main May 30, 2024
46 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
@lukehutch lukehutch deleted the report-socket-errors branch May 30, 2024 22:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants