-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run the fuzz target on PRs #4378
Open
evverx
wants to merge
2
commits into
secdev:master
Choose a base branch
from
evverx:cifuzz
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4378 +/- ##
==========================================
+ Coverage 81.56% 82.19% +0.62%
==========================================
Files 352 352
Lines 84032 84032
==========================================
+ Hits 68544 69072 +528
+ Misses 15488 14960 -528
|
evverx
commented
May 15, 2024
evverx
force-pushed
the
cifuzz
branch
2 times, most recently
from
May 15, 2024 08:28
5e247e7
to
6558716
Compare
evverx
force-pushed
the
cifuzz
branch
2 times, most recently
from
May 23, 2024 08:56
000abd7
to
954523e
Compare
using https://google.github.io/oss-fuzz/getting-started/continuous-integration/ It downloads the corpus OSS-Fuzz has accumulated so far (including the test cases that triggered issues in the past) and runs the fuzz target with it. It should help to catch most regressions when PRs are opened. Prompted by secdev#4373.
to make it possible to turn it off with logging.disable(). (it should help to make the fuzz target less chatty among other things because it seems to be the only dissector (covered by the fuzz target) printing messages like that directly)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using https://google.github.io/oss-fuzz/getting-started/continuous-integration/
It downloads the corpus OSS-Fuzz has accumulated so far (including the test cases that triggered issues in the past) and runs the fuzz target with it. It should help to catch most regressions when PRs are opened.
Prompted by #4373.
It's a draft because to make it more useful in terms of testing
the dissectors should probably be covered first(The dissectors were (partly) covered in google/oss-fuzz#11912).As expected it triggered
https://github.com/secdev/scapy/actions/runs/8941500042/job/24561958924?pr=4378