-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3007.x] Code Coverage for smb testing with Salt 3007 branch #66227
base: 3007.x
Are you sure you want to change the base?
Conversation
Blocked due to tools vm testing failures, for example on centos-7
So just how are PR tests working for centos-7 and Salt 3007 ?
|
Moved this to RHEL 9 and no issues similar to RHEL 7, but running into issue with smb daemon failing to start due to pipe failures which appears to be environment. Moving this to blocked until have more time to work on the issue. Given this was for code-coverage, more important issues to fight at the moment |
What does this PR do?
Added support for smb testing, and ported smb test from unittest to pytestd, adding smbprotocol, and pyspnego pinned dependencies.
Need to add samba support to Golden Images for smbd to be available
What issues does this PR fix or reference?
Fixes: #64747
Previous Behavior
SMB testing was skipped due to smbprotocol and smbd not being available
New Behavior
SMB testing is now enabled, once smbd (samba) is added to Golden Images.
Testing is on Linux platforms only.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.