Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3007.x] Code Coverage for smb testing with Salt 3007 branch #66227

Open
wants to merge 2 commits into
base: 3007.x
Choose a base branch
from

Conversation

dmurphy18
Copy link
Contributor

What does this PR do?

Added support for smb testing, and ported smb test from unittest to pytestd, adding smbprotocol, and pyspnego pinned dependencies.
Need to add samba support to Golden Images for smbd to be available

What issues does this PR fix or reference?

Fixes: #64747

Previous Behavior

SMB testing was skipped due to smbprotocol and smbd not being available

New Behavior

SMB testing is now enabled, once smbd (samba) is added to Golden Images.
Testing is on Linux platforms only.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dmurphy18 dmurphy18 self-assigned this Mar 13, 2024
@dmurphy18 dmurphy18 requested a review from a team as a code owner March 13, 2024 21:34
@dmurphy18 dmurphy18 requested review from felippeb and removed request for a team March 13, 2024 21:34
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Code Coverage for smb testing with Salt 3007 branch [3007.x] Code Coverage for smb testing with Salt 3007 branch Mar 13, 2024
@dmurphy18
Copy link
Contributor Author

Blocked due to tools vm testing failures, for example on centos-7

[root@ip-10-2-12-27 testing]# nox -e 'test-zeromq-3(coverage=False)' -- -vvv --run-slow --log-level=DEBUG --log-cli-level=DEBUG --log-file-level=DEBUG tests/pytests/unit/utils/test_user.py 2>&1 | tee ~/mytest.log
nox > Running session test-zeromq-3(coverage=False)
nox > Re-using existing virtual environment at .nox/test-zeromq-3-coverage-false.
nox > Session test-zeromq-3(coverage=False) was successful.
nox > Running session test-parametrized-3(crypto=None, transport='zeromq', coverage=False)
nox > Re-using existing virtual environment at .nox/test-parametrized-3-crypto-none-transport-zeromq-coverage-false.
nox > python -m pip install --progress-bar=off -U setuptools pip wheel
nox > Command python -m pip install --progress-bar=off -U setuptools pip wheel failed with exit code 1:
ERROR: Cannot install setuptools because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested setuptools
    The user requested (constraint) setuptools<69.0,>=65.6.3

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/user_guide/#fixing-conflicting-dependencies
nox > Session test-parametrized-3(crypto=None, transport='zeromq', coverage=False) failed.
nox > Ran multiple sessions:
nox > * test-zeromq-3(coverage=False): success
nox > * test-parametrized-3(crypto=None, transport='zeromq', coverage=False): failed
[root@ip-10-2-12-27 testing]# python3 -m pip list | grep setup
DEPRECATION: The default format will switch to columns in the future. You can use --format=(legacy|columns) (or define a format=(legacy|columns) in your pip.conf under the [list] section) to disable this warning.
setuptools (39.2.0)
[root@ip-10-2-12-27 testing]#

So just how are PR tests working for centos-7 and Salt 3007 ?
On amazonlinux-2 for the same test (not part of PR changes)

[root@ip-10-2-8-247 testing]# nox -e 'test-zeromq-3(coverage=False)' -- -vvv --run-slow --log-level=DEBUG --log-cli-level=DEBUG --log-file-level=DEBUG tests/pytests/unit/utils/test_user.py 2>&1 | tee ~/mytest.log
nox > Running session test-zeromq-3(coverage=False)
nox > Re-using existing virtual environment at .nox/test-zeromq-3-coverage-false.
nox > Session test-zeromq-3(coverage=False) was successful.
nox > Running session test-parametrized-3(crypto=None, transport='zeromq', coverage=False)
nox > Re-using existing virtual environment at .nox/test-parametrized-3-crypto-none-transport-zeromq-coverage-false.
nox > python -m pip install --progress-bar=off -U setuptools pip wheel
nox > Session test-parametrized-3(crypto=None, transport='zeromq', coverage=False) aborted: Only Python >= 3.8 is supported.
nox > Ran multiple sessions:
nox > * test-zeromq-3(coverage=False): success
nox > * test-parametrized-3(crypto=None, transport='zeromq', coverage=False): aborted
[root@ip-10-2-8-247 testing]# 

@dmurphy18
Copy link
Contributor Author

Moved this to RHEL 9 and no issues similar to RHEL 7, but running into issue with smb daemon failing to start due to pipe failures which appears to be environment. Moving this to blocked until have more time to work on the issue. Given this was for code-coverage, more important issues to fight at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant