[DOC] Adjust doc for rb_ary_new_capa #10774
Draft
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* "Designed capacity of the generating array" becomes: * "Desired capacity of the array" * "this could be effective than" becomes: * "this could be more efficient than" * I'm not sure what "how many rooms of objects it allocates" means. * Instead use "the `capa` parameter to specify the length of the array." * This is not to be confused with the `Array#length`... * Removed excess spaces mid-sentence
|
Ahh, I realized the spaces are because the text is meant to be justified to 80 characters. 🤔 |
shyouhei
reviewed
May 16, 2024
Comment on lines
+80
to
+84
| * Identical to rb_ary_new(), except it accepts the `capa` parameter to specify | ||
| * the length of the array. | ||
| * | ||
| * @param[in] capa Designed capacity of the generating array. | ||
| * This way you can create an array whose capacity is bigger than the length of | ||
| * it. If you can say that an array grows to a specific amount, this could be |
There was a problem hiding this comment.
"The length" that appear twice in this part seems something different each other. It is confusing to non-native English speakers like me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
capaparameter to specify the length of the array."Array#length...