[ntuple] store streamer info of unsplit fields #15556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverweed
reviewed
May 17, 2024
Test Results 12 files 12 suites 2d 20h 23m 48s ⏱️ For more details on these failures, see this check. Results for commit 3266abb. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
May 20, 2024
jblomer
force-pushed
the
ntuple-unsplit-streamerinfo
branch
from
d7ab319
to
e5d43f0
Compare
pcanal
approved these changes
May 29, 2024
jblomer
force-pushed
the
ntuple-unsplit-streamerinfo
branch
from
e5d43f0
to
3266abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #14728
Stores the streamer info records seen during serialization of unsplit fields in the extra type information of the extension header. To this end, proper serialization and deserialization of the extra type information frame in the header / extension header is implemented.
This will be accompanied by a roottest PR (TODO)