[ntuple] remove checksum field from anchor #15553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...instead of relying on ReadClassBuffer(). This is necessary for schema evolution with RNTuple's custom streamer.
Checksum is now excluded from the on-disk representation and it's not stored in the anchor. This allows to leverage the ROOT I/O machinery for schema evolution rather than having to rely entirely on custom code in RNTuple::Streamer(). The RNTuple class version gets bumped from 4 to 5. This is a breaking change, but backwards compatibility with version 4 will be preserved for a while for easing the transition. Support for version 4 will be dropped before stabilization.
silverweed
force-pushed
the
ntuple_no_checksum_field
branch
from
effb3ac
to
3b6f0d1
Compare
64 was missing the 2 bytes of the version
Test Results 9 files 9 suites 2d 4h 3m 21s ⏱️ For more details on these failures, see this check. Results for commit ddc93d0. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
May 17, 2024
jblomer
changed the title
jblomer
approved these changes
May 21, 2024
jblomer
reviewed
May 21, 2024
pcanal
reviewed
May 21, 2024
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checksum is now excluded from the on-disk representation and it's not
stored in the anchor. This allows to leverage the ROOT I/O machinery for
schema evolution rather than having to rely entirely on custom code in
RNTuple::Streamer().
The RNTuple class version gets bumped from 4 to 5.
This is a breaking change, but backwards compatibility with version 4
will be preserved for a while for easing the transition. Support for
version 4 will be dropped before stabilization.
Checklist: