[jsroot] newer three.js, many fixes #15544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module includes components from three.js extras which provided in examples
Test Results 11 files 11 suites 2d 12h 30m 57s ⏱️ Results for commit 8221f57. ♻️ This comment has been updated with latest results. |
1. Correctly scale size of axis ticks - take into account NDC axis length 2. Remove source_dir output in node.js root-project#296 3. Set name and userData in geometry `build()` function root-project#303 4. Draw histogram title afterwards - place in front of stats box 5. Upgrade three.js r158 -> r162, last with WebGL1 support 6. Split extras into three_addons.mjs, provide jsroot geometry build without three.js 7. Fix - correctly draw only grids with AXIG draw option 8. Fix - let read object from TFile with empty name 9. Fix - graph drawing fix custom labels on X axis root-project#297 10. Fix - draw at least line for TGraphErrors ROOT-8131 11. Fix - log scales on TH3 drawings root-project#306 12. Fix - preserve attributes and draw options when call drawingJSON() root-project#307 13. Fix - draw geometry top node volume if all childs not visible root-project#308 14. Fix - canvas resize in Qt5 window
bellenot
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build()function TGeoPainter build method doesn't fill name and other Object3d fields jsroot#303