Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[interpreter] Enable LLVM_ENABLE_ABI_BREAKING_CHECKS #15536

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented May 16, 2024

The comment mentions LLVM 5.0 and we now set stricter visibility
options, so this should not be a problem anymore.
Copy link

github-actions bot commented May 16, 2024

Test Results

     8 files       8 suites   1d 23h 26m 50s ⏱️
 2 597 tests  2 581 ✅ 0 💤 16 ❌
19 839 runs  19 746 ✅ 0 💤 93 ❌

For more details on these failures, see this check.

Results for commit ce37690.

♻️ This comment has been updated with latest results.

Copy link
Member

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lgtm!

@hahnjo hahnjo added the clean build Ask CI to do non-incremental build on PR label May 17, 2024
@hahnjo
Copy link
Member Author

hahnjo commented May 17, 2024

Except it doesn't work yet, as now also shown by a clean build in the CI; there are some issues left to be fixed

@vgvassilev
Copy link
Member

Except it doesn't work yet, as now also shown by a clean build in the CI; there are some issues left to be fixed

Annoying... llvm does not allow people to get away easily :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean build Ask CI to do non-incremental build on PR in:Cling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants