Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RF] Small fixup for using RooFit with new Clad 1.5 #15502

Merged
merged 1 commit into from
May 21, 2024

Conversation

guitargeek
Copy link
Contributor

@guitargeek guitargeek commented May 14, 2024

Using template functions in the generated code can cause linker errors,
which is avoided with this suggested commit.

To be backported to the 6.32 branch.

Copy link

github-actions bot commented May 14, 2024

Test Results

     9 files       9 suites   2d 3h 1m 9s ⏱️
 2 636 tests  2 635 ✅ 0 💤 1 ❌
22 350 runs  22 343 ✅ 0 💤 7 ❌

For more details on these failures, see this check.

Results for commit 3b3d8f7.

♻️ This comment has been updated with latest results.

@vgvassilev
Copy link
Member

I thought we have fixed that bug in clad. Can we get a reproducer?

@guitargeek
Copy link
Contributor Author

No, that one is not fixed, and in fact I can't reproduce it locally.

But it is very easy to circumvent: just done use std::min and std::max, like we currently do:
https://github.com/root-project/root/blob/master/roofit/roofitcore/inc/RooFit/Detail/MathFuncs.h#L547

I tried in this PR to use the std:: functions just to see what happens, but it didn't work. It's not a blocker though.

@vgvassilev
Copy link
Member

No, that one is not fixed, and in fact I can't reproduce it locally.

But it is very easy to circumvent: just done use std::min and std::max, like we currently do: https://github.com/root-project/root/blob/master/roofit/roofitcore/inc/RooFit/Detail/MathFuncs.h#L547

I tried in this PR to use the std:: functions just to see what happens, but it didn't work. It's not a blocker though.

Do we have a bug report for it?

Using template functions in the generated code can cause linker errors,
which is avoided with this suggested commit.

To be backported to the 6.32 branch.
@guitargeek guitargeek marked this pull request as ready for review May 21, 2024 15:45
@guitargeek guitargeek requested a review from lmoneta as a code owner May 21, 2024 15:45
@guitargeek guitargeek changed the title [RF] Continue RooFit AD development [RF] Small fixup for using RooFit with new Clad 1.5 May 21, 2024
@guitargeek
Copy link
Contributor Author

I have repurposed this PR to fix the current CI failures.

Copy link
Member

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@vepadulano
Copy link
Member

FYI the clad update also introduces an unused parameter warning due to

Double_t *result, const Int_t result_size) {
. I don't know if you want to include the fix in this PR or I will just open a separate one

@vepadulano
Copy link
Member

PR open at #15589

@guitargeek guitargeek merged commit a2d3663 into root-project:master May 21, 2024
11 of 13 checks passed
@guitargeek guitargeek deleted the roofit_ad_dev branch May 21, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants