-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RF] Small fixup for using RooFit with new Clad 1.5 #15502
Conversation
Test Results 9 files 9 suites 2d 3h 1m 9s ⏱️ For more details on these failures, see this check. Results for commit 3b3d8f7. ♻️ This comment has been updated with latest results. |
5a606f5
to
04a3b8e
Compare
I thought we have fixed that bug in clad. Can we get a reproducer? |
No, that one is not fixed, and in fact I can't reproduce it locally. But it is very easy to circumvent: just done use I tried in this PR to use the |
Do we have a bug report for it? |
Using template functions in the generated code can cause linker errors, which is avoided with this suggested commit. To be backported to the 6.32 branch.
I have repurposed this PR to fix the current CI failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
FYI the clad update also introduces an unused parameter warning due to root/hist/hist/src/TFormula.cxx Line 3161 in baf0923
|
PR open at #15589 |
Using template functions in the generated code can cause linker errors,
which is avoided with this suggested commit.
To be backported to the 6.32 branch.