Proc Type API - Groove's Worst Mistake #513
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switch underlying data from bool[] to byte[], add GetRaw versions of public mask access
|
Removed draft status because most of the initial issues have been addressed. Deployment is still a concern. Testing looks good so far; if anyone has time to run some tests of their own I'd appreciate it. |
|
I'll need to think for redeployment for making it generic ish so that other modules would need to do it it would work in a fast manner, it could be that no one but me have any idea on how to do it lol |
xiaoxiao921
reviewed
Apr 10, 2024
|
|
||
| [[build.copy]] | ||
| source = "./ReleaseOutput" | ||
| target = "./plugins/R2API.ProcType" |
There was a problem hiding this comment.
missing another entry for the patcher afaik
[[build.copy]]
source = "./ReleaseOutput/PATCHER_DLL"
target = "./patchers/"
| outdir = "./build" | ||
|
|
||
| [[build.copy]] | ||
| source = "./ReleaseOutput" |
There was a problem hiding this comment.
source = "./ReleaseOutput/PLUGIN_DLL.dll" instead of the whole folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of custom Proc Types that is not limited by the vanilla mask size. Patches a field onto
RoR2.ProcChainMaskto store modded proc chain mask information.This is a draft because documentation/readme is not complete, the implementation is still up for debate, and it would currently not deploy properly (hoping someone else can deal with this).
Main Components are:
ReserveProcTypeand theAddModdedProc,RemoveModdedProc, andHasModdedProcextensions which mirrorProcChainMask.AddProc,ProcChainMask.RemoveProc, andProcChainMask.HasProcRoR2.ProcChainMaskto hold modded data