Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

🐞 fix: return method for api with task type #1897

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

starriv
Copy link

@starriv starriv commented May 10, 2022

fix #1888

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1751fd6:

Sandbox Source
one Configuration

@watsonhaw5566
Copy link
Contributor

@starriv 这里是缺少了一个 completeArg的方法吗?单元测试试过了没

@starriv
Copy link
Author

starriv commented May 20, 2022

@starriv 这里是缺少了一个 completeArg的方法吗?单元测试试过了没

不是缺少 completeArg 方法、是针对部分 task 类型需要继续返回、以前是直接 resolve 了结果

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #1897 (1751fd6) into master (f180dd9) will decrease coverage by 0.04%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##           master    #1897      +/-   ##
==========================================
- Coverage   90.39%   90.35%   -0.05%     
==========================================
  Files         391      391              
  Lines        4768     4779      +11     
  Branches      692      731      +39     
==========================================
+ Hits         4310     4318       +8     
- Misses        449      452       +3     
  Partials        9        9              
Impacted Files Coverage Δ
packages/remax-framework-shared/src/promisify.ts 88.00% <81.25%> (-12.00%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sydeEvans
Copy link
Member

@starriv 覆盖率可以看一下

@watsonhaw5566
Copy link
Contributor

@starriv 这里是缺少了一个 completeArg的方法吗?单元测试试过了没

不是缺少 completeArg 方法、是针对部分 task 类型需要继续返回、以前是直接 resolve 了结果

单测覆盖一下就好了,感谢你的 pr

@starriv
Copy link
Author

starriv commented May 21, 2022

@starriv 这里是缺少了一个 completeArg的方法吗?单元测试试过了没

不是缺少 completeArg 方法、是针对部分 task 类型需要继续返回、以前是直接 resolve 了结果

单测覆盖一下就好了,感谢你的 pr

OK 我来补一下

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]微信小程序使用导出的uploadFile无法调用onProgressUpdate监听文件上传进度
3 participants