Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack CTA #2102

Merged
merged 3 commits into from
May 20, 2024
Merged

Slack CTA #2102

merged 3 commits into from
May 20, 2024

Conversation

miguelgfierro
Copy link
Collaborator

@miguelgfierro miguelgfierro commented May 17, 2024 •
edited

Description

Improvement on top of #2096 so people can join the slack channel

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • I have signed the commits, e.g. git commit -s -m "your commit message".
  • This PR is being made to staging branch AND NOT TO main branch.

@miguelgfierro
Slack CTA
df667a5 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
width
9659dcd 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
width 300
0f7ad9e 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
Copy link
Collaborator Author

This is how it looks like:
image

It link to the LF server, and then people would need to join #recommenders channel

FYI @anargyri @SimonYansenZhao

@miguelgfierro
Copy link
Collaborator Author

FYI @daviddavo, in case you are around

@miguelgfierro miguelgfierro merged commit 15b72f4 into staging May 20, 2024
1 check passed
@miguelgfierro miguelgfierro deleted the miguel/slack_cta branch May 20, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loomlike loomlike loomlike approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

@SimonYansenZhao SimonYansenZhao Awaiting requested review from SimonYansenZhao SimonYansenZhao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miguelgfierro @loomlike