Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropbox: add option to override root namespace #7821

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

wfraser
Copy link
Contributor

@wfraser wfraser commented May 3, 2024

What is the purpose of this change?

This lets you, for example, use shared folders without mounting them into your home namespace first, as long as you know their namespace ID.

(The --dropbox-shared-folders flag could thus be changed to not need to mount the shared folder first, but I'm not doing that here as it's a behavior change, who knows, maybe somebody relies on it.)

This also allows access to your Dropbox Backups hidden namespace once you figure out what its namespace ID is.

Was the change discussed in an issue or in the forum before?

Checklist

  • I have read the contribution guidelines.
  • I have added tests for all changes in this PR if appropriate.
  • I have added documentation for the changes if appropriate.
  • All commit messages are in house style.
  • I'm done, this Pull Request is ready for review :-)

This lets you, for example, use shared folders without mounting them
into your home namespace first, as long as you know their namespace ID.

(The --dropbox-shared-folders flag could thus be changed to not need to
mount the shared folder first, but I'm not doing that here as it's a
behavior change, who knows, maybe somebody relies on it.)
Copy link
Member

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change looks great thank you.

I'd just like to have a discussion about the naming.

In other backends we have called this feature like this

      --box-root-folder-id string          Fill in for rclone to use a non root folder as its starting point
      --drive-root-folder-id string        ID of the root folder
      --filefabric-root-folder-id string   ID of the root folder
      --onedrive-root-folder-id string     ID of the root folder
      --pcloud-root-folder-id string       Fill in for rclone to use a non root folder as its starting point (default "d0")
      --pikpak-root-folder-id string       ID of the root folder
      --sharefile-root-folder-id string    ID of the root folder

So I'm tempted to say we should do the same for the dropbox backend too and call this --dropbox-root-folder-id to fit in with the rest of rclone.

However dropbox have their very specific naming with namespaces so maybe it isn't a good idea. We could of course write lots of help explaining things.

What do you think?

I'll run the CI now too.

@wfraser
Copy link
Contributor Author

wfraser commented May 13, 2024

Thanks for the review!

I think calling it "folder ID" here would be more confusing, because it needs to specifically be a namespace ID and not a file/folder ID (which is a different kind of identifier in the Dropbox API).

@ncw
Copy link
Member

ncw commented Jun 11, 2024

Thank you :-)

I'll merge this now.

@ncw ncw merged commit 7c0645d into rclone:master Jun 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants