-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of Map Zones #8100
base: master
Are you sure you want to change the base?
Conversation
* Implements Map Zones which allows easier configuration of map settings. * The restricted mapflag has been removed as they will no longer be needed. * General cleanups and optimizations.
* Convert a few more PK damage checks that got missed from a merge conflict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments
Thanks to @SapitoSucio!
* Deprecate the bg_flee_penalty and gvg_flee_penalty battle configs. * Removes hardcoded restrictions limiting to only BG and GvG maps.
* Adjust checks for faster lookup.
* Re-implement battle_calc_pk_damage to help determine when to adjust damage when PK mode is enabled. * Implement INF2_IGNOREPKREDUCTION skill flag to make skills bypass the damage adjustments.
* Remove a possible timer even if passing an invalid time value.
* Check by object type rather than passing arbitrary integers to compare against.
Can something like these be added?
It will be much easier to enable set of items only (ex: Booster equipment) |
* Added the Clear label to allow mapflags to be removed for importing use. * Converts mapflag storage into multimap.
* Adds back an accidental removal for mapflag name lookup.
* Display a notice when a map doesn't have a zone with a suggestion to assign one. * Avoiding a default zone as many maps are added from updates and may not get their proper zones until the requisite data is found.
Thanks to @Pokye!
* Fixes atcommands pvpon, pvpoff, gvgon, and gvgoff to properly toggle the current map with the appropriate zone. * Atcommand pvpon will assign the MAPTYPE_NOPENALTY_FREEPKZONE zone. * Atcommand gvgon will assign the MAPTYPE_EVENT_GUILDWAR zone. * Adds getMapZone() to return a map's zone. * Adds setZone() to set a map's zone. Thanks to @Atemo!
* Revert atcommand pvpon/pvpoff. * Revert atcommand gvgon/gvgoff.
I'll gladly accept this as a feature request after the initial implementation gets put in just to keep "custom" parts of this separate. |
* Adjust to class to avoid duplication of definitions. * Rename prefix to match "class".
Thanks to @Lemongrass3110!
# Conflicts: # conf/msg_conf/map_msg.conf
Addressed Issue(s): N/A
Server Mode: Pre-renewal and Renewal
Description of Pull Request: