Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Longing for Freedom making players stuck #7957

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes Longing for Freedom making players stuck #7957

wants to merge 3 commits into from
+7 −0

Conversation

aleos89
Copy link
Contributor

@aleos89 aleos89 commented Oct 4, 2023

  • Addressed Issue(s): Fixes Longing for Freedom #7777

  • Server Mode: Pre-renewal

  • Description of Pull Request:

    • Fixes Longing for Freedom making players not be able to walk after songs have ended.
      Thanks to @XanKriegor1!

@aleos89
Fixes Longing for Freedom making players stuck
0e50ba6 
* Fixes #7777.
* Fixes Longing for Freedom making players not be able to walk after songs have ended.
Thanks to @XanKriegor1!
@aleos89 aleos89 added component:skill A fault that deals specifically with a skill priority:low A fault that affects rAthena in one piece of functionality and is self-contained mode:prerenewal A fault that exists within the pre-renewal mode status:code-review Pull Request that requires reviewing from other developers before being pushed to master type:bug Issue that is a bug within rAthena hacktoberfest-accepted Hacktoberfest event, can be merged later. labels Oct 4, 2023
@aleos89
Fixes Longing for Freedom for real
3df537e
@aleos89
Properly remove movement restriction
b759efe 
* Remove the movement restriction from Longing for Freedom when it becomes active with an Ensemble skill.
@Daraen1
Copy link
Contributor

Daraen1 commented Mar 13, 2024

I have asked on rathena discord if the behavior is correct, but no answer after 3 days.
So if one of our contributors can confirm or deny if still buggy, it would be cool for everyone.
Video show how it works for now.
You can't attack but you can skill, I think it's not correct, you should able to attack too.
Thank you.
https://www.youtube.com/watch?v=uOXRHjYip2k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component:skill A fault that deals specifically with a skill hacktoberfest-accepted Hacktoberfest event, can be merged later. mode:prerenewal A fault that exists within the pre-renewal mode priority:low A fault that affects rAthena in one piece of functionality and is self-contained status:code-review Pull Request that requires reviewing from other developers before being pushed to master type:bug Issue that is a bug within rAthena
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Longing for Freedom
2 participants
@aleos89 @Daraen1