update(cirq-rigetti): use pyquil v4 #6281
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jselig-rigetti
force-pushed
the
rigetti-use-pyquil-v4
branch
2 times, most recently
from
d8c1e61
to
1787c12
Compare
| raise ValueError(f'Symbols not valid for region name {region_name}') | ||
| qam_execution_result = quantum_computer.qam.run(executable) | ||
| qam_execution_result = quantum_computer.qam.run(executable, memory_map) |
There was a problem hiding this comment.
We need to check for atomic values and wrap them in a list to prevent a breaking change here.
In v3, Program.write_memory accepted atomic values for memory regions of length 1. For example, Program.write_memory("ro", 1) was valid if ro was defined as DECLARE ro BIT[1]. In v4, the new MemoryMap only accepts sequences of values for a memory region, even if that memory region happens to be length 1.
There was a problem hiding this comment.
fixed this in the lines above 👍
|
Hey @jselig-rigetti @MarquessV Can either of you please review rigetti/qcs-api-client-python#12? It's been causing incompatibility issues with Cirq. |
jselig-rigetti
requested review from
vtomole,
cduck and
a team
as code owners
jselig-rigetti
force-pushed
the
rigetti-use-pyquil-v4
branch
from
6ed2e90
to
34dd7f1
Compare
jselig-rigetti
force-pushed
the
rigetti-use-pyquil-v4
branch
2 times, most recently
from
86fa3dc
to
c5f7f3a
Compare
jselig-rigetti
force-pushed
the
rigetti-use-pyquil-v4
branch
from
c5f7f3a
to
48027f6
Compare
|
@jselig-rigetti @MarquessV Hey, how's this PR going? |
|
Hey @vtomole! This PR is ready to review from our perspective. Anything else you need us to do? |
Ah thank you, rigetti/pyquil#1782 will merge soon which should clear that up |
Sounds great. Please consider applying the patch at the comment #6281 (comment) here. |
|
|
||
|
|
||
| @_provide_default_client # pragma: no cover | ||
| # pragma: no cover |
There was a problem hiding this comment.
The # pragma: no cover comment is ineffective here.
Please move to the end of the line 238, ie, the end of the def statement to
ignore coverage for the entire get_rigetti_qcs_aspen_device function.
Better yet, adding a unit test would be nicer, even with a mock of the get_instruction_set_architecture function.
PS: to test the coverage and if # pragma: no cover comments apply you can use
$ check/pytest --rigetti-integration cirq-rigetti/ --cov=cirq_rigetti --cov-report=html
and then inspect the htmlcov/index.html file.
…e as_qvm when constructing service class Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
|
Thank you @jselig-rigetti ! |
- Add support for Kraus operators, POVMs and parametric defgates - Update quil->cirq conversion Fixes quantumlib#6500 Partially implements quantumlib#6464
Refactors as necessary to anticipate the release of PyQuil v4. Changes between the RC used here and the eventual full release should be compatible, but leave this MR as a draft until the dependency can be pinned to a full
>=4.0.0release.