This repository has been archived by the owner on Jun 5, 2020. It is now read-only.
#214 Add the ability to configure health check params #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@misnyo your change looks good in principle, but it needs rebasing on top of the current master, and please change it to two-space indents to match the rest of the codebase. |
…rams indentation fixed
|
@DavidS done, please review! |
|
Can you also add a health check to https://github.com/puppetlabs/puppetlabs-aws/blob/master/spec/acceptance/loadbalancer_spec.rb#L43 and a check that it actually succeeded around L100 there? |
|
Needs a rebase again. |
|
I'll try to get a good AWS module session in next week, where I will go through and see whether I can integrate a big chunk of all currently open PRs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve part of the #214 enhancement