Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rds): cleanup RDS test cases #4003

Merged
merged 2 commits into from
May 20, 2024

Conversation

madereddy
Copy link
Contributor

Context

Cleanup RDS test cases to remove assert search.

Description

Cleanup RDS test cases to remove assert search and replace with assert.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@madereddy madereddy requested review from a team as code owners May 14, 2024 18:54
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label May 14, 2024
@madereddy
Copy link
Contributor Author

Competing with #4004 and #4002

Recommended to merge this one last.

jfagoagas
jfagoagas previously approved these changes May 20, 2024
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up following our coding guide 👏

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label May 20, 2024
@sergargar sergargar requested a review from jfagoagas May 20, 2024 14:53
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.65%. Comparing base (45ccd7e) to head (acb4d20).
Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4003      +/-   ##
==========================================
+ Coverage   86.51%   86.65%   +0.13%     
==========================================
  Files         768      777       +9     
  Lines       23899    24237     +338     
==========================================
+ Hits        20677    21002     +325     
- Misses       3222     3235      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergargar sergargar self-requested a review May 20, 2024 15:13
@sergargar sergargar merged commit 6c632dd into prowler-cloud:master May 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants