Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CSV importer tests and visit duration query for imported data #4114

Merged
merged 4 commits into from
May 21, 2024

Conversation

zoldar
Copy link
Contributor

@zoldar zoldar commented May 20, 2024

Changes

This PR applies post-merge feedback from #4096 (review) (h/t @ruslandoga) and changes visit duration computation in imported data query to be in line with native one, always rounding to full integers instead of first decimal place.

Tests

  • Automated tests have been added

Copy link
Contributor

@RobertJoonas RobertJoonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zoldar zoldar merged commit 7876802 into master May 21, 2024
7 checks passed
@zoldar zoldar deleted the improve-csv-importer-tests branch May 21, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants