-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: event leak in graphics pipe #10560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR title doesn't match the required format. The title should be in this format:
chore: update Text docs
fix: text not rendering
feat: add new feature to Text
breaking: remove Text#resolution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR title doesn't match the required format. The title should be in this format:
chore: update Text docs
fix: text not rendering
feat: add new feature to Text
breaking: remove Text#resolution
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR title doesn't match the required format. The title should be in this format:
chore: update Text docs
fix: text not rendering
feat: add new feature to Text
breaking: remove Text#resolution
Description of change
Fixes a graphics leak, where we were re-adding the graphcis object onDestroy event on each rebuild - rather than just the once on init. This PR fixes it.
There was also a second update list that was not being cleared (or used!) so i removed it.
Pre-Merge Checklist
npm run lint
)npm run test
)fixes #10549