Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: masks interfering with interaction #10557

Merged
merged 1 commit into from
May 21, 2024
Merged

fix: masks interfering with interaction #10557

merged 1 commit into from
May 21, 2024

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented May 20, 2024

Interaction wasn't checking if the container is measurable or in the build which meant that some masks where being included in the interaction checks

@Zyie Zyie requested a review from GoodBoyDigital May 20, 2024 15:01
@pixijs pixijs deleted a comment from korbit-ai bot May 20, 2024
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 71451fb:

Sandbox Source
pixi.js-sandbox Configuration

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your code and did not find any issues!


Please note that I can make mistakes, and you should still encourage your team to review your code as well.

@Zyie Zyie added ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t v8 labels May 20, 2024
@Zyie Zyie added this pull request to the merge queue May 21, 2024
Merged via the queue into dev with commit 0c7f26d May 21, 2024
5 checks passed
@Zyie Zyie deleted the fix/mask-interaction branch May 21, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t v8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants