-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait after restarting FTL before trying to check version #5613
base: development-v6
Are you sure you want to change the base?
Conversation
Signed-off-by: DL6ER <dl6er@dl6er.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with rdwebdesign. We should be not have an infinite loop that depends on outside conditions (network availability). I think we should have a counter and exit the loop after e.g. 10 seconds and ask users to manually run the update command afterwards.
I am not sure where my mind was when I first responded to RD's comment. Reading over the code again, actually it probably is a fair shout that we timeout after x seconds (the user could always |
The script is constantly adding The suggested alternative is erroring out with no option for the user to wait longer if 10 seconds isn't enough to restart FTL on their RPi Zero with 100,000 queries to import from the database. Sure, the timeout could be 60 seconds but my opinion is that waiting "forever" and constantly showing that the script is still alive is the proper way to do this |
I know we had this before, but maybe the answer changed in-between: do we have any signal that would signal FTL's readiness to accept DNS queries (e.g. a second pid file)? This PR is not about FTL only. The cat might have unplugged the cable just at the right moment - FTL might be ready for a long time, but there would be no network connectivity. |
We could I hear you and you are right, it's about more than FTL alone. However, without connectivity, there is no (simple) way the updater can exit gracefully. |
|
FTLinstall "${binary}" | ||
restart_service pihole-FTL | ||
enable_service pihole-FTL | ||
str="Restarting FTL..." | ||
echo -ne " ${INFO} ${str}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, the timeout could be 60 seconds but my opinion is that waiting "forever" and constantly showing that the script is still alive is the proper way to do this
Should we add here a text explaining FTL can take some time to restart and the process can loop forever without a connection? ("this can take several seconds")
Should we add "Press CTRL+C to exit"?
Or something like a simplified version of this spinner?
What does this implement/fix?
Prevent errors like seen in #5608 (comment) when Pi-hole uses itself as
nameserver
:Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.