Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSDoc and type for parent property #6815

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lgtome
Copy link

@lgtome lgtome commented May 9, 2024

Please do not update the README or Change Log, we will do this when we merge your PR.

This PR

  • Updates JSDoc
  • Fixes a bug

Describe the changes below:

I was using typescript and I found a mismatching property with JSDoc and typescript.
image
Here is the screenshot with JSDoc and an error from typescript.
I added null type for JSDoc.

Thank you!

@photonstorm
Copy link
Collaborator

Thanks for the PR - could you please remove the types def from it, we only need the JSDoc change itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants