Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: delete pages PDF action #6772

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented May 19, 2024

Proposed change

I think this should be the last of these. Hardest part was deciding the UI, went with a visual solution in the end. Like rotate, this modifies the original.

Screenshot 2024-05-19 at 8 24 28 AM Screenshot 2024-05-19 at 8 24 47 AM

Closes #528

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested review from a team as code owners May 19, 2024 15:25
@paperless-ngx-secretary paperless-ngx-secretary bot added backend documentation Improvements or additions to documentation frontend non-trivial Requires approval by several team members labels May 19, 2024
@github-actions github-actions bot added the enhancement New feature label May 19, 2024
@shamoon shamoon changed the title Feature: delete pages PDF action Enhancement: delete pages PDF action May 19, 2024
@shamoon shamoon enabled auto-merge (squash) May 20, 2024 16:40
@shamoon shamoon removed the documentation Improvements or additions to documentation label May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (2116964) to head (b13a68c).

Current head b13a68c differs from pull request most recent head 4f4765c

Please upload reports for the commit 4f4765c to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6772      +/-   ##
==========================================
+ Coverage   97.19%   97.21%   +0.01%     
==========================================
  Files         436      438       +2     
  Lines       17981    18065      +84     
  Branches     1440     1498      +58     
==========================================
+ Hits        17477    17561      +84     
+ Misses        504      501       -3     
- Partials        0        3       +3     
Flag Coverage Δ
backend 95.89% <100.00%> (+0.01%) ⬆️
frontend 98.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shamoon shamoon added this to the Next Release milestone May 20, 2024
@shamoon shamoon force-pushed the feature-delete-pages-action branch from b13a68c to 4f4765c Compare May 22, 2024 22:54
@shamoon shamoon merged commit 3e62f13 into dev May 22, 2024
25 checks passed
@shamoon shamoon deleted the feature-delete-pages-action branch May 22, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature frontend non-trivial Requires approval by several team members
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants