-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce bun.dns.prefetch
API
#11176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarred-Sumner
changed the title
Introduce bun.dns.prefetch API
Introduce May 19, 2024
bun.dns.prefetch
API
zackradisic
reviewed
May 19, 2024
cirospaciari
approved these changes
May 19, 2024
mangs
reviewed
May 19, 2024
Comment on lines
+76
to
+78
cacheHitsCompleted: number; | ||
cacheHitsInflight: number; | ||
cacheMisses: number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be useful to see these values per hostname as well to see where lookup activity is concentrated. could generate some useful graphs from this too.
Co-authored-by: Eric L. Goldstein <3359116+mangs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds the
bun.dns.prefetch
API.Like
<link rel="dns-prefetch">
in browsers, the intended usecase is to amortize the cost of DNS lookups you know you'll make soon.This also sets the DNS cache to have a TTL of 30 seconds. For reference, the Java Virtual Machine has no TTL set and AWS recommends 5 seconds.
This also introduces a
dns.getCacheStats()
API which exposes information about the DNS cache.This also adds documentation.
This also makes
bun install
prefetch the DNS query.How did you verify your code works?
There is a test