Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace [bun.MAX_PATH_BYTES + 1]u8 with bun.PathBuffer #11163

Merged
merged 2 commits into from
May 22, 2024

Conversation

nektro
Copy link
Contributor

@nektro nektro commented May 18, 2024

MAX_PATH_BYTES already includes room for the sentinel

made this is separate PR so it can audited independently

Copy link

github-actions bot commented May 18, 2024

@nektro, your commit has failing tests :(

💪 3 failing tests Darwin AARCH64

💻 3 failing tests Darwin x64 baseline

💻 4 failing tests Darwin x64

🐧💪 1 failing tests Linux AARCH64

🐧🖥 1 failing tests Linux x64 baseline

🐧🖥 1 failing tests Linux x64

🪟💻 14 failing tests Windows x64 baseline

🪟💻 14 failing tests Windows x64

View logs

@nektro nektro requested a review from Jarred-Sumner May 18, 2024 08:29
@Jarred-Sumner Jarred-Sumner merged commit e5de03b into main May 22, 2024
45 of 53 checks passed
@Jarred-Sumner Jarred-Sumner deleted the nektro-patch-22888 branch May 22, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants