Move Events methods to namespace #4692
Conversation
| }; | ||
| namespace tfs::events { | ||
|
|
||
| bool load(); |
There was a problem hiding this comment.
I prefer to change this for each events::x, as it gives us better control over each type. However, this approach will result in repeated code and reading the same file multiple times. I suggest this because I plan to add global events and move events to the namespace.
like
tfs::events::global::startup();
tfs::events::global::shutdown();
tfs::events::global::save();
| @@ -260,8 +259,7 @@ ReturnValue Combat::canDoCombat(Creature* caster, Tile* tile, bool aggressive) | |||
| if (aggressive && tile->hasFlag(TILESTATE_PROTECTIONZONE)) { | |||
| return RETURNVALUE_ACTIONNOTPERMITTEDINPROTECTIONZONE; | |||
| } | |||
|
|
|||
| return g_events->eventCreatureOnAreaCombat(caster, tile, aggressive); | |||
| return tfs::events::creature::onAreaCombat(caster, tile, aggressive); | |||
There was a problem hiding this comment.
I'm still unsure whether to use tfs::events or tfs::game::events. What do you think?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| namespace tfs::events { | ||
|
|
||
| bool load() |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
|
@ranisalt to what extent is it good to use namespace to handle all singletons? |
Singletons are I like this post on how singletons are an awful idea in general. Namespaces don't solve it, but they make it less bad. |
EvilHero90
added
the
enhancement
Pull Request Prelude
Changes Proposed