Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thoughts on global usings? #270

Merged
merged 1 commit into from
May 23, 2024
Merged

thoughts on global usings? #270

merged 1 commit into from
May 23, 2024

Conversation

SimonCropp
Copy link
Contributor

No description provided.

oskardudycz
oskardudycz approved these changes May 23, 2024
View reviewed changes
Copy link
Owner

@oskardudycz oskardudycz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an ultimate fan of Global Usings, especially if they target external dependencies, as I prefer to see them explicitly. Still, changes in this Pull Request make sense, as they are either using internal references or Ms-related common code.

@oskardudycz oskardudycz merged commit 6171bb4 into oskardudycz:main May 23, 2024
1 of 2 checks passed
@SimonCropp SimonCropp deleted the global-usings branch May 23, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskardudycz oskardudycz oskardudycz approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SimonCropp @oskardudycz