Allow users to set number of partitions in topic #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orlangure
reviewed
May 19, 2024
|
Hey @karelbilek, I merged a bunch of other PRs, so if you still want to merge this, please rebase and resolve the conflicts. Thanks! |
karelbilek
force-pushed
the
add-topic-configs
branch
from
b6d2373
to
9c82dca
Compare
|
Done, plus I added a test that the topics are created successfully with the proper partitions. (I... think. I am myself using a different kafka library than gnomock is using.) |
I have added new type, TopicConfig, and added it to options WithTopicConfig in backwards-compatible way For now it just has topic name and number of partitions, but it can be enhanced in the future with other options. I wanted to also add a replication count, but there is just one broker in the cluster, so it makes no sense.
karelbilek
force-pushed
the
add-topic-configs
branch
from
9c82dca
to
43e4f8f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1040 +/- ##
===========================================
- Coverage 85.87% 64.40% -21.48%
===========================================
Files 50 55 +5
Lines 2350 2618 +268
===========================================
- Hits 2018 1686 -332
- Misses 173 809 +636
+ Partials 159 123 -36 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added new type, TopicConfig, and added it to options WithTopicConfig in backwards-compatible way.
For now it just has topic name and number of partitions, but it can be enhanced in the future with other options.
I wanted to also add a replication count, but there is just one broker in the cluster, so it makes no sense.
Fixes #1031