Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-33417: Provide SCC access via RBAC #28806

Merged
merged 3 commits into from
May 20, 2024
Merged

[release-4.14] OCPBUGS-33417: Provide SCC access via RBAC #28806

merged 3 commits into from
May 20, 2024
+320,163 −171,327

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented May 16, 2024

/assign @cblecker

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 16, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 16, 2024
@openshift-ci-robot
Copy link

@soltysh: This pull request references Jira Issue OCPBUGS-33417, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-33347 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-33347 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact:
/cc @dpuniaredhat

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/assign @cblecker

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added e2e-images-update Related to images used by e2e tests vendor-update Touching vendor dir or related files approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 16, 2024
@cblecker
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@prb112 prb112 mentioned this pull request May 19, 2024
Open
@soltysh
Copy link
Member Author

soltysh commented May 20, 2024

/label backport-risk-assessed
/retest-required

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 20, 2024
@gangwgr
Copy link
Contributor

gangwgr commented May 20, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 20, 2024
@soltysh
Copy link
Member Author

soltysh commented May 20, 2024

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2024 •
edited

@soltysh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 ad40adc link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-metal-ipi-sdn ad40adc link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-single-node-upgrade ad40adc link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-agnostic-ovn-cmd ad40adc link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-upgrade ad40adc link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-etcd-recovery ad40adc link false /test e2e-aws-etcd-recovery
ci/prow/e2e-aws-ovn-single-node-serial ad40adc link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-cgroupsv2 ad40adc link false /test e2e-aws-ovn-cgroupsv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4687f49 and 2 for PR HEAD ad40adc in total

@soltysh
Copy link
Member Author

soltysh commented May 20, 2024

/override ci/prow/e2e-gcp-ovn-builds
based on https://issues.redhat.com/browse/OCPBUGS-33486

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2024

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-gcp-ovn-builds

In response to this:

/override ci/prow/e2e-gcp-ovn-builds
based on https://issues.redhat.com/browse/OCPBUGS-33486

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit d44a62a into openshift:release-4.14 May 20, 2024
16 of 24 checks passed
@openshift-ci-robot
Copy link

@soltysh: Jira Issue OCPBUGS-33417: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33417 has been moved to the MODIFIED state.

In response to this:

/assign @cblecker

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@soltysh soltysh deleted the bugs_33417 branch May 20, 2024 17:32
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.14.0-202405201837.p0.gd44a62a.assembly.stream.el8 for distgit openshift-enterprise-tests.
All builds following this will include this PR.

@jkyros jkyros mentioned this pull request May 20, 2024
Closed
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2024-05-20-155905

@dtantsur dtantsur mentioned this pull request May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpuniaredhat dpuniaredhat Awaiting requested review from dpuniaredhat

@bparees bparees Awaiting requested review from bparees

@frobware frobware Awaiting requested review from frobware

Assignees

@dgoodwin dgoodwin

@cblecker cblecker

@adambkaplan adambkaplan

@sayan-biswas sayan-biswas

@kasturinarra kasturinarra

@jadhaj jadhaj

@pamoedom pamoedom

@jitendar-singh jitendar-singh

@prietyc123 prietyc123

@gangwgr gangwgr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. e2e-images-update Related to images used by e2e tests jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet