-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on Ubuntu 24.04 and Qt 6 #5144
Conversation
gcovr 7.0, packaged in Ubuntu 24.04 Universe, fails to parse large coverage files.
os: [ ubuntu-20.04, ubuntu-22.04 ] | ||
os: [ ubuntu-20.04, ubuntu-22.04, ubuntu-24.04 ] | ||
qt: [ qt5, qt6 ] | ||
exclude: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we exclude these? A comment explaining why and if applicable when it can be turned back on would be great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit added with comments:
@@ -16,8 +16,10 @@ jobs:
qt: [ qt5, qt6 ]
exclude:
- os: ubuntu-20.04
+ # Qt 6 not packaged
qt: qt6
- os: ubuntu-22.04
+ # libqscintilla2-qt6-dev not packaged
qt: qt6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@t-paul Let us know if you have any comments/wishes before merging
Some tidying up of github-ci-linux-get-dependencies.sh and its use with old and misnamed Ubuntus and an attempt to avoid similar problems in future by defaulting to ubuntu-latest (although that still does have to be defined in one place).
gcovr completes, but the reports show no coverage - which actually isn't any different to the existing tests on other PRs as far as I can see.
gcovr -r ../src
does seem an improvement ongcovr -r ..
in that it doesn't collect source files from the build directory or submodules.