Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libobs: Add functions to serialize JSON with default values #10693

Merged
merged 2 commits into from
May 26, 2024

Conversation

derrod
Copy link
Member

@derrod derrod commented May 19, 2024

Description

Adds two new functions to serialize obs_data objects to JSON while also including default values.

Motivation and Context

Alternative to #10641 that requires opt-in from the API user. Same motiviation and context.

How Has This Been Tested?

Serialized some data.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the Enhancement Improvement to existing functionality label May 24, 2024
Copy link
Collaborator

@Lain-B Lain-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would recommend documentation (if documentation for this area of functions already exist) but not a big deal one way or another imho

@derrod derrod force-pushed the libobs-serialize-defaults branch from 1db9e5c to 2af45ae Compare May 26, 2024 00:00
@derrod derrod force-pushed the libobs-serialize-defaults branch from 2af45ae to 44b6d6d Compare May 26, 2024 00:01
@Lain-B Lain-B merged commit e54af0d into obsproject:master May 26, 2024
15 checks passed
@derrod derrod deleted the libobs-serialize-defaults branch May 26, 2024 00:29
@RytoEX RytoEX added this to the OBS Studio (Next Version) milestone May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants