fix(next-auth): proper handling of env for createActionURL #10950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next.js replaces environment variables at build time but they need to be reference directly and cannot be accessed dynamically for this to work.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@michaellopez is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Next.js replaces environment variables at build time but they need to be reference directly and cannot be accessed dynamically for this to work. 3c035ec broke this contract.
This PR fixes this by changing the next-auth caller to extract the variables directly from
process.envand putting them in an object compatible withcreateActionURLfrom core. Other frameworks might have other inner workings in regards to this env handling, so I only made the changes in next-auth rather than refactoringcreateActionURLwhich would've affected other frameworks I'm not familiar with.🧢 Checklist
🎫 Affected issues
N/A
📌 Resources